lkml.org 
[lkml]   [2015]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] Warnings : Fixed 80 character length warning in rtw_ap.c
    From
    Date
    On Tue, 2015-07-07 at 15:32 -0400, Valdis.Kletnieks@vt.edu wrote:
    > All: Is it time to kill that checkpatch test, or hide it behind a non-default
    > flag, to prevent code churn?

    <shrug> I'm not an 80 column zealot.

    This is for staging isn't it?
    Code churn there is expected and somewhat desired.

    A lot of time, code churn can be useful when it
    reduces the indentation depth.

    For instance, this code could use continue more.

    The longest line in this file is 158 chars, that's
    probably excessive, awk shows 35 lines > 80 chars.

    staging rtl files have a couple hundred lines > 132
    and thousands of lines > 80.




    \
     
     \ /
      Last update: 2015-07-07 23:01    [W:3.433 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site