lkml.org 
[lkml]   [2015]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] HID: i2c-hid: Call device suspend callback before disabling irq
On Jul 07 2015 or thereabouts, Gabriele Mazzotta wrote:
> The irq is most likely required by the suspend callback, so disable it
> only after the callback had been executed.
>
> Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
> ---

Just in case Jiri missed it:
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

Thanks!

Benjamin

> drivers/hid/i2c-hid/i2c-hid.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
> index f77469d..9ed69b5 100644
> --- a/drivers/hid/i2c-hid/i2c-hid.c
> +++ b/drivers/hid/i2c-hid/i2c-hid.c
> @@ -1092,13 +1092,13 @@ static int i2c_hid_suspend(struct device *dev)
> struct hid_device *hid = ihid->hid;
> int ret = 0;
>
> + if (hid->driver && hid->driver->suspend)
> + ret = hid->driver->suspend(hid, PMSG_SUSPEND);
> +
> disable_irq(ihid->irq);
> if (device_may_wakeup(&client->dev))
> enable_irq_wake(ihid->irq);
>
> - if (hid->driver && hid->driver->suspend)
> - ret = hid->driver->suspend(hid, PMSG_SUSPEND);
> -
> /* Save some power */
> i2c_hid_set_power(client, I2C_HID_PWR_SLEEP);
>
> --
> 2.1.4
>


\
 
 \ /
  Last update: 2015-07-07 23:01    [W:0.496 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site