lkml.org 
[lkml]   [2015]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: dgnc: Replace macro with flow control statement by a function
On Sun, Jul 05, 2015 at 11:46:28PM +0530, Arjun Krishna Babu wrote:
> This patch fixes the checkpatch.pl warning:
>
> WARNING: Macros with flow control statements should be avoided
>
> Replace the macro with a function doing the exact same task as the
> macro.
>

No. You haven't understood what DGNC_VERIFY_BOARD() does and have you
even tried to compile this? Surely the compiler will complain that some
paths don't have a return value?

regards,
dan carpenter



\
 
 \ /
  Last update: 2015-07-06 09:41    [W:0.067 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site