Messages in this thread | | | Date | Mon, 6 Jul 2015 10:32:57 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging: dgnc: Replace macro with flow control statement by a function |
| |
On Sun, Jul 05, 2015 at 11:46:28PM +0530, Arjun Krishna Babu wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: Macros with flow control statements should be avoided > > Replace the macro with a function doing the exact same task as the > macro. >
No. You haven't understood what DGNC_VERIFY_BOARD() does and have you even tried to compile this? Surely the compiler will complain that some paths don't have a return value?
regards, dan carpenter
| |