lkml.org 
[lkml]   [2015]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2 2/4] mfd: da9150: Update DT bindings for Fuel-Gauge support
Date
On July 3, 2015 16:19, Lee Jones wrote:

> > @@ -22,6 +23,7 @@ Required properties:
> > Sub-devices:
> > - da9150-gpadc: See Documentation/devicetree/bindings/iio/adc/da9150-
> gpadc.txt
> > - da9150-charger: See Documentation/devicetree/bindings/power/da9150-
> charger.txt
> > +- da9150-fg: See Documentation/devicetree/bindings/power/da9150-fg.txt
>
> Can you send a subsequent patch doing:
>
> s-Documentation/devicetree/bindings/-../-

Yep, can do.

> >
> >
>
> Superfluous '\n' here.

Will remove.

>
> > Example:
> > @@ -40,4 +42,8 @@ Example:
> > da9150-charger {
> > ...
> > };
> > +
> > + da9150-fg {
> > + ...
> > + };
>
> Perhaps a little content wouldn't go amiss here for quick reference.
>
> Saves dipping in and out of the other binding files.
>
> This patch is fine though:
> Acked-by: Lee Jones <lee.jones@linaro.org>
>

Thanks for the ack. Will add a little info in the example.
\
 
 \ /
  Last update: 2015-07-06 16:41    [W:0.049 / U:0.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site