Messages in this thread | | | Date | Mon, 6 Jul 2015 14:22:31 +0100 | From | Martyn Welch <> | Subject | Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality |
| |
On 13/06/15 01:28, Greg Kroah-Hartman wrote: > On Thu, May 28, 2015 at 03:07:05PM +0300, Dmitry Kalinkin wrote: >> This introduces a new dma device that provides a single ioctl call that >> provides DMA read and write functionality to the user space. >> >> Signed-off-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com> >> Cc: Igor Alekseev <igor.alekseev@itep.ru> >> --- >> drivers/staging/vme/devices/vme_user.c | 201 ++++++++++++++++++++++++++++++++- >> drivers/staging/vme/devices/vme_user.h | 11 ++ >> 2 files changed, 209 insertions(+), 3 deletions(-) > > I want to get Martyn's feedback on this, as it's adding a new feature to > the subsystem that he's going to have to maintain. >
Sorry about the *really* late reply, loads of emails some how missed my periodic search of the mailing list.
I'm happy with the addition of DMA, just not sure whether it's worth adding an extra device file just to handle DMA. Could the user space application not just use the control device?
-- Martyn Welch (Lead Software Engineer) | Registered in England and Wales GE Intelligent Platforms | (3828642) at 100 Barbirolli Square T +44(0)1327322748 | Manchester, M2 3AB E martyn.welch@ge.com | VAT:GB 927559189
| |