lkml.org 
[lkml]   [2015]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] cris: arch-v10: kernel: kgdb: let is_dyn_brkp as extern variable
For upstream cris toolchain (gcc is 6.0, gas and ld are 2.25.51), they
can not recognize the static variable between embedded global asm code
and local C code.

So let it as extern variable to let the related code pass building, it
is harmless for real world using (although it is not quite well for
coding styles).

The related error (with allmodconfig under cris for next-20150702):

arch/cris/arch-v10/kernel/built-in.o: In function `kgdb_handle_breakpoint':
(.text+0x2aca): undefined reference to `is_dyn_brkp'
arch/cris/arch-v10/kernel/built-in.o: In function `is_static':
kgdb.c:(.text+0x2ada): undefined reference to `is_dyn_brkp'


Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
arch/cris/arch-v10/kernel/kgdb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/cris/arch-v10/kernel/kgdb.c b/arch/cris/arch-v10/kernel/kgdb.c
index 22d846b..3553406 100644
--- a/arch/cris/arch-v10/kernel/kgdb.c
+++ b/arch/cris/arch-v10/kernel/kgdb.c
@@ -351,7 +351,7 @@ char internal_stack[INTERNAL_STACK_SIZE];
breakpoint to be handled. A static breakpoint uses the content of register
BRP as it is whereas a dynamic breakpoint requires subtraction with 2
in order to execute the instruction. The first breakpoint is static. */
-static unsigned char is_dyn_brkp = 0;
+unsigned char is_dyn_brkp;

/********************************* String library ****************************/
/* Single-step over library functions creates trap loops. */
--
1.9.3

\
 
 \ /
  Last update: 2015-07-05 10:41    [W:0.055 / U:0.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site