lkml.org 
[lkml]   [2015]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V3] trace/events: add chip name and hwirq to irq entry tracepoint
On Wed, 24 Jun 2015, Steven Rostedt wrote:
> > +
> > +#define show_chip_name(irq) \
> > + (irq_get_irq_data(irq) \
> > + ? irq_get_irq_data(irq)->chip->name \
> > + : "NULL")
> > +
> > +#define show_hwirq(irq) \
> > + (irq_get_irq_data(irq) \
> > + ? irq_get_irq_data(irq)->hwirq \
> > + : -ENODEV)
>
> Note these magic functions will only be useful for the tracefs reads of
> the trace files. Userspace tools that extract the data (like perf and
> trace-cmd), will have no idea of how to parse it.
>
> I'm not against doing this, but I'm just letting you know what the
> effect of this change will be.

What's worse is, that they are racy against a concurrent teardown of
the interrupt. Not a good idea ...

Thanks,

tglx




\
 
 \ /
  Last update: 2015-07-05 23:41    [W:0.072 / U:1.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site