lkml.org 
[lkml]   [2015]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] GPU-DRM: Delete an unnecessary check before drm_property_unreference_blob()
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sun, 5 Jul 2015 21:55:10 +0200

    The drm_property_unreference_blob() function tests whether its argument
    is NULL and then returns immediately.
    Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/gpu/drm/drm_crtc.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
    index 2d57fc5..6e4c8b0 100644
    --- a/drivers/gpu/drm/drm_crtc.c
    +++ b/drivers/gpu/drm/drm_crtc.c
    @@ -4469,9 +4469,7 @@ static int drm_property_replace_global_blob(struct drm_device *dev,
    goto err_created;
    }

    - if (old_blob)
    - drm_property_unreference_blob(old_blob);
    -
    + drm_property_unreference_blob(old_blob);
    *replace = new_blob;

    return 0;
    --
    2.4.5


    \
     
     \ /
      Last update: 2015-07-05 22:21    [W:4.016 / U:0.616 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site