Messages in this thread | | | Date | Sat, 4 Jul 2015 09:20:00 -0400 | From | Steven Rostedt <> | Subject | Re: [RFC][PATCH] x86: Allow early_printk to use console style param like 115200n8 |
| |
On Sat, 4 Jul 2015 13:03:59 +0200 Ingo Molnar <mingo@kernel.org> wrote:
> > + /* > > + * In case the input is like console with text after the baud > > + * rate. e.g. 115200n8. kstrtoul() will error on such input. > > + */ > > + for (p = s; *p && isdigit(*p); p++) > > + ; > > + *p = 0; > > + > > if (kstrtoul(s, 0, &baud) < 0 || baud == 0) > > baud = DEFAULT_BAUD; > >
This was actually one of those cases where I wanted to show that keeping the old function around is better than the alternative ;-)
If people say we need to phase out simple_strtoull(), then I wanted to show what kinds of hacks we will have if that happens.
I was hoping that someone would point out that simple_strtoull() is a better solution. :)
-- Steve
| |