lkml.org 
[lkml]   [2015]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] fs-notify: Deletion of an unnecessary check before the function call "iput"
    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Sat, 29 Nov 2014 16:42:50 +0100
    >
    > The iput() function tests whether its argument is NULL and then
    > returns immediately. Thus the test around the call is not needed.
    >
    > This issue was detected by using the Coccinelle software.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    > ---
    > fs/notify/inode_mark.c | 3 +--
    > 1 file changed, 1 insertion(+), 2 deletions(-)
    >
    > diff --git a/fs/notify/inode_mark.c b/fs/notify/inode_mark.c
    > index 3daf513..d8157a6 100644
    > --- a/fs/notify/inode_mark.c
    > +++ b/fs/notify/inode_mark.c
    > @@ -231,8 +231,7 @@ void fsnotify_unmount_inodes(struct list_head *list)
    > */
    > spin_unlock(&inode_sb_list_lock);
    >
    > - if (need_iput_tmp)
    > - iput(need_iput_tmp);
    > + iput(need_iput_tmp);
    >
    > /* for each watch, send FS_UNMOUNT and then remove it */
    > fsnotify(inode, FS_UNMOUNT, inode, FSNOTIFY_EVENT_INODE, NULL, 0);
    >

    Would anybody like to integrate this update suggestion
    into another source code repository?

    Regards,
    Markus


    \
     
     \ /
      Last update: 2015-07-05 14:01    [W:4.023 / U:0.240 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site