lkml.org 
[lkml]   [2015]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] fs-namespace: Delete unnecessary checks before the function call "mntput"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sat, 4 Jul 2015 11:21:17 +0200

    The mntput() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    fs/namespace.c | 8 ++------
    1 file changed, 2 insertions(+), 6 deletions(-)

    diff --git a/fs/namespace.c b/fs/namespace.c
    index e0b2f36..bc689bd 100644
    --- a/fs/namespace.c
    +++ b/fs/namespace.c
    @@ -2809,12 +2809,8 @@ struct mnt_namespace *copy_mnt_ns(unsigned long flags, struct mnt_namespace *ns,
    p = next_mnt(p, old);
    }
    namespace_unlock();
    -
    - if (rootmnt)
    - mntput(rootmnt);
    - if (pwdmnt)
    - mntput(pwdmnt);
    -
    + mntput(rootmnt);
    + mntput(pwdmnt);
    return new_ns;
    }

    --
    2.4.5


    \
     
     \ /
      Last update: 2015-07-05 13:41    [W:4.757 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site