lkml.org 
[lkml]   [2015]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [f2fs-dev] [PATCH 11/12] f2fs: add noextent_cache mount option
On Thu, Jul 02, 2015 at 08:35:34PM +0800, Chao Yu wrote:
> > -----Original Message-----
> > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org]
> > Sent: Tuesday, June 30, 2015 2:40 AM
> > To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org;
> > linux-f2fs-devel@lists.sourceforge.net
> > Cc: Jaegeuk Kim
> > Subject: [f2fs-dev] [PATCH 11/12] f2fs: add noextent_cache mount option
> >
> > This patch adds noextent_cache mount option.
>
> How about adding some descriptions in Documentation to help our user?
>
> The other thing is we'd better to show 'noextent_cache' option when user
> lookups the mount options.
>
> How about adding codes as below?
> if (test_opt(sbi, EXTENT_CACHE))
> seq_puts(seq, ",extent_cache");
> +else
> + seq_puts(seq, ",noextent_cache");
>

Agreed.

Thanks,

> >
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
>
> The other looks good to me, so please add:
>
> Reviewed-by: Chao Yu <chao2.yu@samsung.com>
>
> ------------------------------------------------------------------------------
> Don't Limit Your Business. Reach for the Cloud.
> GigeNET's Cloud Solutions provide you with the tools and support that
> you need to offload your IT needs and focus on growing your business.
> Configured For All Businesses. Start Your Cloud Today.
> https://www.gigenetcloud.com/
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


\
 
 \ /
  Last update: 2015-07-04 07:41    [W:0.066 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site