Messages in this thread | | | Date | Fri, 3 Jul 2015 09:14:46 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH] tools/perf, rbtree: Add RCU wrappers to make rbtree.h usable in user-space |
| |
On Fri, Jul 03, 2015 at 06:21:12AM +0930, Rusty Russell wrote: > Looks like Peter Zijlstra is the one to take this fix...
acme is the steward of tools/perf/
> >> diff --git a/tools/perf/util/include/linux/rcupdate.h > >> b/tools/perf/util/include/linux/rcupdate.h > >> new file mode 100644 > >> index 0000000..51c0f45 > >> --- /dev/null > >> +++ b/tools/perf/util/include/linux/rcupdate.h > >> @@ -0,0 +1,9 @@ > >> +#ifndef PERF_LINUX_RCUPDATE_H_ > >> +#define PERF_LINUX_RCUPDATE_H_ > >> + > >> +/* Simple trivial wrappers for now, we don't use RCU in perf user-space > >> (yet): */ > >> +#define WRITE_ONCE(var, val) ((var) = (val))
It looks like perf includes linux/compiler.h so it should already have this.
> >> +#define rcu_assign_pointer(ptr, val) WRITE_ONCE(ptr, val)
That's plain wrong, WRITE_ONCE(*(ptr), (val))
| |