lkml.org 
[lkml]   [2015]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 39/41] clocksource: vf_pit: Migrate to new 'set-state' interface
On 03-07-15, 10:10, Stefan Agner wrote:
> > .features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT,
> > - .set_mode = pit_set_mode,
> > + .set_state_shutdown = pit_shutdown,
> > + .set_state_periodic = pit_set_periodic,
>
> I'm not really familiar with the interface, but given that we announce
> the feature CLOCK_EVT_FEAT_ONESHOT shouldn't we add a set_state_oneshot
> callback here?

We weren't doing anything in pit_set_mode(ONESHOT) and so that
callback is not implemented. In case you need to do something in
set_state_oneshot(), we can add it back.

--
viresh


\
 
 \ /
  Last update: 2015-07-03 11:01    [W:0.047 / U:1.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site