lkml.org 
[lkml]   [2015]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] of: constify drv arg of of_driver_match_device stub
On Wed, Jul 1, 2015 at 2:10 AM, Tomeu Vizoso <tomeu.vizoso@collabora.com> wrote:
> With this change the stub has the same signature as the actual function,
> preventing this compiler warning when building without CONFIG_OF:
>
> drivers/base/property.c: In function 'fwnode_driver_match_device':
>>> drivers/base/property.c:608:38: warning: passing argument 2 of 'of_driver_match_device' discards 'const' qualifier from pointer target type
> return of_driver_match_device(dev, drv);
> ^
> In file included from drivers/base/property.c:18:0:
> include/linux/of_device.h:61:19: note: expected 'struct device_driver *' but argument is of type 'const struct device_driver *'
> static inline int of_driver_match_device(struct device *dev,
> ^
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>

Applied. Thanks.

Rob

> ---
> include/linux/of_device.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/of_device.h b/include/linux/of_device.h
> index 4c50854..cc7dd687 100644
> --- a/include/linux/of_device.h
> +++ b/include/linux/of_device.h
> @@ -59,7 +59,7 @@ void of_dma_configure(struct device *dev, struct device_node *np);
> #else /* CONFIG_OF */
>
> static inline int of_driver_match_device(struct device *dev,
> - struct device_driver *drv)
> + const struct device_driver *drv)
> {
> return 0;
> }
> --
> 2.4.1
>


\
 
 \ /
  Last update: 2015-07-28 18:21    [W:0.054 / U:0.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site