lkml.org 
[lkml]   [2015]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] Do not reserve crashkernel high memory if crashkernel low memory reserving failed
    Hi Baoquan,

    thanks for the fix!

    On Sun, Jul 19, 2015 at 10:53:20PM +0800, Baoquan He wrote:
    > People reported that when allocating crashkernel memory using
    > ",high" and ",low" syntax, there were cases where the reservation
    > of the "high" portion succeeds, but the reservation of the "low"
    > portion fails. Then kexec can load kdump kernel successfully, but
    > the boot of kdump kernel fails as there's no low memory. This is
    > because allocation of low memory for kdump kernel can fail on large
    > systems for reasons. E.g it could be manually specified crashkernel
    > low memory is too large to find in memblock region.
    >
    > In this patch add return value for reserve_crashkernel_low. Then put
    > the crashkernel low memory reserving earlier, just between finding
    > the crashkernel high memory region and reserving crashkernel high
    > memory. Then if crashkernel low memory reserving failed we do not
    > reserve crashkernel high memory but return immediately. Users can
    > take measures when they found kdump kernel cann't be loaded
    > successfully.
    >
    > Signed-off-by: Baoquan He <bhe@redhat.com>
    > ---
    > arch/x86/kernel/setup.c | 14 ++++++++------
    > 1 file changed, 8 insertions(+), 6 deletions(-)

    Reviewed-by: Joerg Roedel <jroedel@suse.de>



    \
     
     \ /
      Last update: 2015-07-27 17:01    [W:4.360 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site