lkml.org 
[lkml]   [2015]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] staging: lustre: fixed 80-char rule
On Sat, Jul 25, 2015 at 06:22:52PM +0200, Mario Bambagini wrote:
> This patch fixes 2 lines longer than 80 chars
>
> The first one is a function whose argument has been moved to next line.
> The second one is a comment split on two lines
>
> The script checkpatch does not complain anymore
>
> Signed-off-by: Mario Bambagini <mario.bambagini@gmail.com>
> ---
> drivers/staging/lustre/lustre/llite/llite_capa.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/llite/llite_capa.c b/drivers/staging/lustre/lustre/llite/llite_capa.c
> index 119f017..1f72066 100644
> --- a/drivers/staging/lustre/lustre/llite/llite_capa.c
> +++ b/drivers/staging/lustre/lustre/llite/llite_capa.c
> @@ -70,7 +70,8 @@ static unsigned long long ll_capa_renewal_retries;
>
> static int ll_update_capa(struct obd_capa *ocapa, struct lustre_capa *capa);
>
> -static inline void update_capa_timer(struct obd_capa *ocapa, unsigned long expiry)
> +static inline void update_capa_timer(struct obd_capa *ocapa,
> + unsigned long expiry)

This is wrong. Run your patch through checkpatch.pl --strict and it
will help you.

regards,
dan carpenter



\
 
 \ /
  Last update: 2015-07-26 21:21    [W:0.113 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site