lkml.org 
[lkml]   [2015]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 4/6] perf,tools: save misc sample read value in struct perf_sample
On Fri, Jul 24, 2015 at 09:48:30AM -0400, kan.liang@intel.com wrote:

SNIP

> + u64 nr = 0;
>
> if (sid) {
> sample->id = v->id;
> @@ -1010,6 +1012,20 @@ static int deliver_sample_value(struct perf_evlist *evlist,
> return 0;
> }
>
> + if (perf_evsel__is_group_leader(sid->evsel)) {
> + evsel = sid->evsel;
> + SET_FREQ_PERF_VALUE(evsel, sample->freq_perf_data,
> + sample->read.group.values[nr].value);
> + evlist__for_each_continue(evlist, evsel) {
> + if ((evsel->leader != sid->evsel) ||
> + (++nr >= sample->read.group.nr))
> + break;
> +
> + SET_FREQ_PERF_VALUE(evsel, sample->freq_perf_data,
> + sample->read.group.values[nr].value);

I think this should be in upper layer.. why not do this also
within iter_prepare_normal_entry as for the rest of the calculations
I suggested in my other email

jirka


\
 
 \ /
  Last update: 2015-07-26 19:01    [W:0.131 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site