lkml.org 
[lkml]   [2015]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/4] cp210x: Store part number
From
Date
On Fri, 2015-07-24 at 08:48 +0200, Petr Tesarik wrote:
> @@ -872,6 +886,12 @@ static int cp210x_startup(struct usb_serial
> *serial)
>
> usb_set_serial_data(serial, spriv);
>
> + /* Get the 1-byte part number of the cp210x device */
> + cp210x_control_msg(serial->port[0], CP210X_VENDOR_SPECIFIC,
> + REQTYPE_DEVICE_TO_HOST, CP210X_GET_PARTNUM,
> + &partnum, 1, USB_CTRL_GET_TIMEOUT);
> + spriv->bPartNumber = partnum & 0xFF;

DMA on the stack. That breaks the cache coherency rules.
You must kmalloc the buffer.

Regards
Oliver




\
 
 \ /
  Last update: 2015-07-26 16:01    [W:0.115 / U:1.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site