Messages in this thread | | | Date | Sun, 26 Jul 2015 11:52:52 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH v2 4/4] irqchip: Add bcm2836 interrupt controller for Raspberry Pi 2. |
| |
On Mon, 13 Jul 2015, Eric Anholt wrote: > +static void > +bcm2836_arm_irqchip_smp_init(void) > +{ > +#ifdef CONFIG_SMP > + int i; > + > + /* unmask IPIs */ > + for_each_possible_cpu(i) { > + bcm2836_arm_irqchip_unmask_per_cpu_irq( > + LOCAL_MAILBOX_INT_CONTROL0, 0, i);
Do you really want to enable these interrupts on all possible cpus? Why so?
Shouldn't that be done at the point where a hotplugged CPU is starting ?
Thanks,
tglx
| |