lkml.org 
[lkml]   [2015]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] power: max17042_battery: add HEALTH and TEMP_* properties support
Hi,

On Mon, Jul 27, 2015 at 09:34:13AM +0900, Krzysztof Kozlowski wrote:
>>> [...]
>>
>> I missed this email (may be overlooked it). To have the
>> interrupts enabled we need the config registers(0x1Dh) bit's
>> BIT(9), BIT(4) and BIT92) should be 1 and BIT(8) should be 0.
>>
>> Can you dump the status(00h), Talrt(02H) Temp(08h) and
>> config(1Dh) registers values and share?
>
> Thanks for responding. The issue was in BIT(8) which was set to default
> value of 0x1. This would mean to use external sensor but the board does
> not have it.
>
> This is a DT platform and there is no initial config data so all
> registers are set to default values.
>
> Anyway everything seems to work as expected, thanks for explanation.

So I guess the bit should be set to 0 during probe. Maybe with a
boolean DT property "maxim,has-external-sensor" for setting it
to 1.

-- Sebastian
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-07-27 03:41    [W:0.072 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site