[lkml]   [2015]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 3/4] power: Add Qualcomm SMBB driver

On Thu, Jun 18, 2015 at 02:13:44PM -0700, Bjorn Andersson wrote:
> Add the Qualcomm Switch-Mode Battery Charger and Boost driver, found in
> pm8941.

The driver's sourcecode looks fine to me. I'm not convinced by all
those new DT properties, though. I think "watermark" should be
replaced with "threshold" and "control" with "current" for all
properties. Additionally some comments. Note, that I only used the
driver's sourcecode as reference, since the DT binding document
was neither send to me, nor to linux-pm mailinglist.

* battery-charge-control-limit

It's unclear, what this property is used for. Is the limit only
for "normal" charging or also for fast charging?

* fast-charge-low-watermark
* fast-charge-high-watermark

Add a unit to this property. Maybe "fast-charge-start-voltage"
and "fast-charge-stop-voltage"?

* fast-charge-safe-voltage
* fast-charge-safe-current

These properties are fine to me. I wonder if they should be named
fast-charge-max-*, though.

* auto-recharge-low-watermark

I think the "low" can be dropped. Instead a -voltage
should be appended, since it could also be a percentage.

* minimum-input-voltage

Add a vendor prefix to this property.

* usb-charge-control-limit

I suggest to remove this from DT. If no USB detection is
implemented, the default should be 100mA according to USB

* dc-charge-control-limit

Please add a vendor prefix and I think "dc-current-limit"
is a more fitting name.

* disable-dc

Please add a vendor prefix.

* jeita-extended-temp-range

Looks ok to me.

-- Sebastian

[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2015-07-25 18:01    [W:0.096 / U:0.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site