lkml.org 
[lkml]   [2015]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] Staging: fbtft: Add support for the Ultrachip UC1611 LCD controller

    Den 14.07.2015 14:59, skrev Henri Chain:
    > This is a driver chip for 240x160 4-bit greyscale LCDs.
    > It is capable of 4-wire (8 bit) or 3-wire (9 bit) SPI that have both been
    > tested. (It also has a 6800 or 8080-style parallel interface, but I have
    > not included support for it.)
    >
    > Signed-off-by: Henri Chain <henri.chain@eleves.ec-nantes.fr>
    > ---

    > diff --git a/drivers/staging/fbtft/fb_uc1611.c b/drivers/staging/fbtft/fb_uc1611.c

    > +static int init_display(struct fbtft_par *par)
    > +{
    > + int ret;
    > +
    > + fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, "%s()\n", __func__);
    > +
    > + /* Set CS active high */
    > + par->spi->mode |= SPI_CS_HIGH;

    Why is this set here and not in fbtft_device along side SPI_MODE_3?

    > +static int set_var(struct fbtft_par *par)
    > +{
    > + fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, "%s()\n", __func__);
    > +
    > + /* par->info->fix.visual = FB_VISUAL_PSEUDOCOLOR; */

    This comment can be removed I guess.



    \
     
     \ /
      Last update: 2015-07-23 15:21    [W:6.735 / U:1.308 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site