lkml.org 
[lkml]   [2015]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 03/10] mm, page_alloc: Remove unnecessary recalculations for dirty zone balancing
    On Tue, Jul 21, 2015 at 05:08:42PM -0700, David Rientjes wrote:
    > On Mon, 20 Jul 2015, Mel Gorman wrote:
    >
    > > From: Mel Gorman <mgorman@suse.de>
    > >
    > > File-backed pages that will be immediately dirtied are balanced between
    > > zones but it's unnecessarily expensive. Move consider_zone_balanced into
    > > the alloc_context instead of checking bitmaps multiple times.
    > >
    > > Signed-off-by: Mel Gorman <mgorman@suse.de>
    >
    > Acked-by: David Rientjes <rientjes@google.com>
    >

    Thanks.

    > consider_zone_dirty eliminates zones over their dirty limits and
    > zone_dirty_ok() returns true if zones are under their dirty limits, so the
    > naming of both are a little strange. You might consider changing them
    > while you're here.

    Yeah, that seems sensible. I named the struct field spread_dirty_page so
    the relevant check now looks like

    if (ac->spread_dirty_page && !zone_dirty_ok(zone))

    Alternative suggestions welcome but I think this is more meaningful than
    consider_zone_dirty was.

    --
    Mel Gorman
    SUSE Labs


    \
     
     \ /
      Last update: 2015-07-23 15:01    [W:4.638 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site