Messages in this thread | | | From | Jes Sorensen <> | Subject | Re: [PATCH] staging: rtl8723au: fix incorrect type in assignment warning | Date | Wed, 22 Jul 2015 13:56:42 -0400 |
| |
Steve Pennington <sgpenn@gmail.com> writes: > Repaced calls to htons and memcpy with a single call to put_unaligned_be16
You may want an 'l' in replaced, but not a biggie to me.
> to fix the following sparse warning: > drivers/staging/rtl8723au/core/rtw_recv.c:1557:21: warning: incorrect type in assignment (different base types) > drivers/staging/rtl8723au/core/rtw_recv.c:1557:21: expected unsigned short [unsigned] [assigned] [usertype] len > drivers/staging/rtl8723au/core/rtw_recv.c:1557:21: got restricted __be16 [usertype] <noident> > > Signed-off-by: Steve Pennington <sgpenn@gmail.com> > --- > drivers/staging/rtl8723au/core/rtw_recv.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8723au/core/rtw_recv.c b/drivers/staging/rtl8723au/core/rtw_recv.c > index 274a4b6..ad0549c 100644 > --- a/drivers/staging/rtl8723au/core/rtw_recv.c > +++ b/drivers/staging/rtl8723au/core/rtw_recv.c > @@ -1554,8 +1554,7 @@ static int wlanhdr_to_ethhdr (struct recv_frame *precvframe) > ether_addr_copy(ptr + ETH_ALEN, pattrib->src); > > if (!bsnaphdr) { > - len = htons(len); > - memcpy(ptr + 12, &len, 2); > + put_unaligned_be16(len, ptr + 12); > }
This one looks good to me.
Jes
| |