Messages in this thread | | | Subject | Re: [PATCH V6 1/4] efi: x86: rearrange efi_mem_attributes() | From | "Zhang, Jonathan Zhixiong" <> | Date | Wed, 22 Jul 2015 10:21:27 -0700 |
| |
Appreciate Matt for your ack.
On 7/22/2015 4:11 AM, Matt Fleming wrote: > On Mon, 20 Jul, at 05:32:36PM, Jonathan (Zhixiong) Zhang wrote: >> From: "Jonathan (Zhixiong) Zhang" <zjzhang@codeaurora.org> >> >> x86 and ia64 implement efi_mem_attributes() differently. This >> function needs to be available for other arch (such as arm64) >> as well, such as for the purpose of ACPI/APEI. >> >> ia64 efi does not setup memmap variable and does not set >> EFI_MEMMAP flag, so it needs to have its unique implementation >> of efi_mem_attributes(). >> >> Move efi_mem_attributes() implementation from x86 to efi, and >> declare it with __weak. It is recommended that other archs >> should not override the default implementation. >> >> Signed-off-by: Jonathan (Zhixiong) Zhang <zjzhang@codeaurora.org> >> --- >> arch/x86/platform/efi/efi.c | 18 ------------------ >> drivers/firmware/efi/efi.c | 31 +++++++++++++++++++++++++++++++ >> 2 files changed, 31 insertions(+), 18 deletions(-) > > Reviewed-by: Matt Fleming <matt.fleming@intel.com> >
-- Jonathan (Zhixiong) Zhang The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
| |