lkml.org 
[lkml]   [2015]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRE: [PATCH V4] x86/mm/pat: Do a small optimization and fix in reserve_memtype
Date


---
Robert Elliott, HP Server Storage

> -----Original Message-----
> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-
> owner@vger.kernel.org] On Behalf Of Pan Xinhui
> Sent: Wednesday, July 22, 2015 8:27 AM
...
> diff --git a/arch/x86/mm/pat.c b/arch/x86/mm/pat.c
> index 188e3e0..8fa1f07 100644
> --- a/arch/x86/mm/pat.c
> +++ b/arch/x86/mm/pat.c
> @@ -521,10 +521,7 @@ int reserve_memtype(u64 start, u64 end, enum
> page_cache_mode req_type,
>
> is_range_ram = pat_pagerange_is_ram(start, end);
> if (is_range_ram == 1) {
> -
> - err = reserve_ram_pages_type(start, end, req_type, new_type);
> -
> - return err;
> + return reserve_ram_pages_type(start, end, req_type, new_type);
> } else if (is_range_ram < 0) {
> return -EINVAL;
> }

With each branch now just one line, the {} can be removed.



\
 
 \ /
  Last update: 2015-07-22 17:01    [W:0.170 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site