lkml.org 
[lkml]   [2015]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 3/4] serial: 8250_dw: Add UPF_FIXED_TYPE to flags
Date
From: Noam Camus <noamc@ezchip.com>

Always add UPF_FIXED_TYPE to flags so autoconf() will be skipped.
We do that since autoconf() performs many writes to LCR that cause
BUSY interrupt.
The problem with such interrupt is that driver is not yet called to
request_irq() and generic IRQ subsystem will mask the UART line.

Signed-off-by: Noam Camus <noamc@ezchip.com>
---
drivers/tty/serial/8250/8250_dw.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index 1a57105..620f983 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -362,6 +362,14 @@ static int dw8250_probe_of(struct uart_port *p,
if (has_ucv)
dw8250_setup_port(up);

+ /* Writing to LCR may cause BUSY interrupt before we
+ * register the IRQ line.
+ * Currently autoconf() uses several writes to LCR.
+ * In order to avoid calling to autoconf() always add
+ * following flag.
+ */
+ p->flags |= UPF_FIXED_TYPE;
+
/* if we have a valid fifosize, try hooking up DMA here */
if (p->fifosize) {
up->dma = &data->dma;
--
1.7.1


\
 
 \ /
  Last update: 2015-07-22 12:01    [W:0.145 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site