Messages in this thread | | | From | "Luis R. Rodriguez" <> | Date | Tue, 21 Jul 2015 16:14:02 -0700 | Subject | Re: [RFC v3 2/2] firmware: add firmware signature checking support |
| |
On Tue, Jul 14, 2015 at 12:20 PM, Luis R. Rodriguez <mcgrof@suse.com> wrote: >> > + strcpy(signed_name, buf->fw_id); >> > + strncat(signed_name, sign_ext, strlen(sign_ext)); >> >> fw_id is potentially unbounded, so using strncat hear poses an >> overflow risk. Maybe better to use strlcpy? >> > > Thanks for the feedback, indeed.
Ok I've made this change based on David's tree.
Luis
| |