Messages in this thread | | | Date | Tue, 21 Jul 2015 17:53:09 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: Kernel broken on processors without performance counters |
| |
On Tue, 21 Jul 2015, Peter Zijlstra wrote: > On Tue, Jul 21, 2015 at 05:43:27PM +0200, Thomas Gleixner wrote: > > > > +#define static_branch_inc(_k) static_key_slow_inc(&(_k)->key) > > > > +#define static_branch_dec(_k) static_key_slow_dec(&(_k)->key) > > > > Inlines please > > > > > > +/* > > > > + * Normal usage; boolean enable/disable. > > > > + */ > > > > + > > > > +#define static_branch_enable(_k) static_key_enable(&(_k)->key) > > > > +#define static_branch_disable(_k) static_key_disable(&(_k)->key) > > > > Ditto > > > > All in all much more understandable than the existing horror. > > They cannot in fact be inlines because we play type tricks. Note how _k > can be either struct static_likely_key or struct static_unlikely_key.
Indeed. Care to add a comment?
Thanks,
tglx
| |