lkml.org 
[lkml]   [2015]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] tracing: Introduce two additional marks for delay
From
Date
On Jul 22, 2015, at 12:09 AM, Steven Rostedt wrote:
> On Tue, 21 Jul 2015 23:56:31 +0900
> Jungseok Lee <jungseoklee85@gmail.com> wrote:
>
>
>
>> Recently, I've noticed that there is a minor, not logical, flaw in the
>> above hunk as reviewing patches which do not get any signals yet. It is
>> a lack of 's' in msec in comment. That is, my latest one is as follows.
>>
>> + MARK(100000000ULL , '@'), /* 100 msecs */
>> + MARK(10000000ULL , '*'), /* 10 msecs */
>>
>> I know it's definitely trivial, but I've updated it to align with other
>> comments and planned to resend the patch. Surprisingly, this patch
>> has been already staged on your repo. So, I leave a whole patch again
>> including your SOB since I don't know how to handle this.
>>
>> Thanks you for reviewing my patch!
>
> The original is in the process of going through my tests. I waited till
> rc3 to come out to rebase all my work on it (including this patch) and
> restated testing again. I tripped on some things that are still buggy
> in -rc3 (which delays the finishing of my testing).
>
> As it is in the testing phase, I wont be modifying it. If you want,
> just send another patch on top of my ftrace/core branch, and I can add
> that to my queue too.

Thanks for a kind explanation.
I think it is not needed to create another patch for only this change.

Best Regards
Jungseok Lee


\
 
 \ /
  Last update: 2015-07-21 17:41    [W:0.048 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site