lkml.org 
[lkml]   [2015]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH RFC V5 2/4] perf,tool: per-event time support
On Tue, Jul 21, 2015 at 03:39:17AM +0000, Liang, Kan wrote:

SNIP

> > + case PERF_EVSEL__CONFIG_TERM_PERIOD:
> > + attr->sample_period = term->val.period;
> > + default:
> > + break;
> > + }
> > + }
> > +}
> > +
> > /*
> > * The enable_on_exec/disabled value strategy:
> > *
> > @@ -773,6 +789,8 @@ void perf_evsel__config(struct perf_evsel *evsel,
> > struct record_opts *opts)
> > attr->use_clockid = 1;
> > attr->clockid = opts->clockid;
> > }
> > +
> > + apply_config_terms(attr, &evsel->config_terms);
> > }
> >
>
> Other options/event modifier may also change the sample_period.
> E.g. sample read.
> So I think we may move it to the beginning of perf_evsel__config.

well, it's at the end to ensure we do the event specific setting
after everything else is done

if you set this together with group leader sampling for non leader
event, I guess you know what you're doing.. right?

jirka


\
 
 \ /
  Last update: 2015-07-21 17:21    [W:0.063 / U:0.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site