Messages in this thread | | | Date | Tue, 21 Jul 2015 12:11:18 +0530 | From | Sudip Mukherjee <> | Subject | Re: [Intel-gfx] [PATCH v2] drm/i915: remove unnecessary null test |
| |
On Mon, Jul 20, 2015 at 05:33:50PM +0200, Daniel Vetter wrote: > On Mon, Jul 20, 2015 at 08:36:01PM +0530, Sudip Mukherjee wrote: > > While creating the debugfs file we are setting the inode->i_private to > > dev. That same dev is passed to these functions as private of struct > > seq_file via single_open(). So at this point it can never be NULL. > > > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > > --- > > > > v1 was drm/i915: fix possible null pointer dereference > > There's still one left in i915_displayport_test_active_write. I left it out intentionally as it was not used via single_open(). Will include that and send v3. >Also please mention the commit that introduced these and Cc: the author. > Also please Cc: Chris since he's commented on v1 of this patch. sure, Chris was Cc: in v2 and will Cc: him in v3 also.
regards sudip
| |