lkml.org 
[lkml]   [2015]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: hd0_info and hd1_info are obsolete and unused fields

* Paolo Pisati <p.pisati@gmail.com> wrote:

> hd0_info and hd1_info are not used anymore, don't reference them in the code
>
> Signed-off-by: Paolo Pisati <p.pisati@gmail.com>
> ---
> arch/x86/kernel/kexec-bzimage64.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/x86/kernel/kexec-bzimage64.c b/arch/x86/kernel/kexec-bzimage64.c
> index 3666a84..c0ae428 100644
> --- a/arch/x86/kernel/kexec-bzimage64.c
> +++ b/arch/x86/kernel/kexec-bzimage64.c
> @@ -218,10 +218,6 @@ setup_boot_parameters(struct kimage *image, struct boot_params *params,
> /* Default APM info */
> memset(&params->apm_bios_info, 0, sizeof(params->apm_bios_info));
>
> - /* Default drive info */
> - memset(&params->hd0_info, 0, sizeof(params->hd0_info));
> - memset(&params->hd1_info, 0, sizeof(params->hd1_info));
> -
> if (image->type == KEXEC_TYPE_CRASH) {
> ret = crash_setup_memmap_entries(image, params);
> if (ret)

But they are not unused: we pass them to secondary kernel images, via kcrash for
example.

So it makes sense to zero out these parameters.

Thanks,

Ingo


\
 
 \ /
  Last update: 2015-07-21 08:21    [W:0.057 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site