Messages in this thread | | | Date | Tue, 21 Jul 2015 12:04:15 +0100 | From | Mark Brown <> | Subject | Re: [PATCH] regulator: rk808: make better use of the gpiod API |
| |
On Tue, Jul 21, 2015 at 11:56:49AM +0200, Linus Walleij wrote: > On Tue, Jul 21, 2015 at 8:59 AM, Uwe Kleine-König
> > The gpiod functions include variants for managed gpiod resources. Use it > > to simplify the remove function.
> > As the driver handles a device node without a specification of dvs gpios > > just fine, additionally use the variant of gpiod_get exactly for this > > use case. This makes error checking more strict.
> > As a third benefit this patch makes the driver use the flags parameter > > of gpiod_get* which will not be optional any more after 4.2 and so > > prevents a build failure when the respective gpiod commit is merged.
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > Mark, please apply this.
...and reverted since it doesn't build as it's adding a use of a new API which doesn't actually exist in Linus' tree yet (hopefully it's in -next). I need a tag to pull if I'm going to use this patch. [unhandled content-type:application/pgp-signature] | |