lkml.org 
[lkml]   [2015]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] regulator: rk808: make better use of the gpiod API
    On Tue, Jul 21, 2015 at 11:56:49AM +0200, Linus Walleij wrote:
    > On Tue, Jul 21, 2015 at 8:59 AM, Uwe Kleine-König

    > > The gpiod functions include variants for managed gpiod resources. Use it
    > > to simplify the remove function.

    > > As the driver handles a device node without a specification of dvs gpios
    > > just fine, additionally use the variant of gpiod_get exactly for this
    > > use case. This makes error checking more strict.

    > > As a third benefit this patch makes the driver use the flags parameter
    > > of gpiod_get* which will not be optional any more after 4.2 and so
    > > prevents a build failure when the respective gpiod commit is merged.

    > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
    >
    > Mark, please apply this.

    ...and reverted since it doesn't build as it's adding a use of a new API
    which doesn't actually exist in Linus' tree yet (hopefully it's in
    -next). I need a tag to pull if I'm going to use this patch.
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2015-07-21 13:21    [W:3.658 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site