lkml.org 
[lkml]   [2015]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ppc4xx_edac: Fix kernel oops
On Tue, Jul 21, 2015 at 11:00:53AM +0200, Michael Walle wrote:
> The commit de3910eb79ac8c0f29a11224661c0ebaaf813039 changed the memory
> allocation for the csrows member. But ppc4xx_edac was forgotten in the
> patch. Fix it.
>
> This is warning reported by the compiler:
>
> drivers/edac/ppc4xx_edac.c: In function 'ppc4xx_edac_init_csrows':
> drivers/edac/ppc4xx_edac.c:924:28: warning: initialization from
> incompatible pointer type [enabled by default]
> struct csrow_info *csi = &mci->csrows[row];
>
> Cc: Doug Thompson <dougthompson@xmission.com>
> Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
> Cc: linux-edac@vger.kernel.org
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> drivers/edac/ppc4xx_edac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/edac/ppc4xx_edac.c b/drivers/edac/ppc4xx_edac.c
> index 0f04d5e..4c1991d 100644
> --- a/drivers/edac/ppc4xx_edac.c
> +++ b/drivers/edac/ppc4xx_edac.c
> @@ -921,7 +921,7 @@ static int ppc4xx_edac_init_csrows(struct mem_ctl_info *mci, u32 mcopt1)
> */
>
> for (row = 0; row < mci->nr_csrows; row++) {
> - struct csrow_info *csi = &mci->csrows[row];
> + struct csrow_info *csi = mci->csrows[row];
>
> /*
> * Get the configuration settings for this

Applied, thanks.

Your $Subject says "Fix kernel oops" - do we need to mark this one for
stable? It fixing a real bug and all...

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--


\
 
 \ /
  Last update: 2015-07-21 12:01    [W:0.045 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site