Messages in this thread | | | Date | Mon, 20 Jul 2015 10:45:32 -0700 | From | Bjorn Andersson <> | Subject | Re: [PATCH] backlight: pm8941-wled: Move PM8941 WLED driver to backlight |
| |
On Mon 20 Jul 07:22 PDT 2015, Jingoo Han wrote:
> On Thursday, July 16, 2015 5:02 AM, Bjorn Andersson wrote: > > > > The Qualcomm PM8941 WLED block is used for backlight and should therefor > > be in the backlight framework and not in the LED framework. This moves > > the driver and adapts to the backlight api instead. > > > > Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com> > > --- > > .../devicetree/bindings/leds/leds-pm8941-wled.txt | 5 +- > > drivers/leds/Kconfig | 8 --- > > drivers/leds/Makefile | 1 - > > drivers/video/backlight/Kconfig | 8 +++ > > drivers/video/backlight/Makefile | 1 + > > .../backlight/pm8941-wled.c} | 59 ++++++++++------------ > > 6 files changed, 36 insertions(+), 46 deletions(-) > > rename drivers/{leds/leds-pm8941-wled.c => video/backlight/pm8941-wled.c} (90%) > > > > diff --git a/Documentation/devicetree/bindings/leds/leds-pm8941-wled.txt > > b/Documentation/devicetree/bindings/leds/leds-pm8941-wled.txt > > index a85a964d61f5..424f8444a6cd 100644 > > --- a/Documentation/devicetree/bindings/leds/leds-pm8941-wled.txt > > +++ b/Documentation/devicetree/bindings/leds/leds-pm8941-wled.txt > > Please move this txt file to 'backlight' directory. >
Of course
[..]
> > diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig > > index 0505b796d743..6c67c5430933 100644 > > --- a/drivers/video/backlight/Kconfig > > +++ b/drivers/video/backlight/Kconfig > > @@ -299,6 +299,14 @@ config BACKLIGHT_TOSA > > If you have an Sharp SL-6000 Zaurus say Y to enable a driver > > for its backlight > > > > +config BACKLIGHT_PM8941_WLED > > + tristate "Qualcomm PM8941 WLED Driver" > > + depends on LEDS_CLASS > > LEDS_CLASS? > Please check your patch carefully. >
Sorry about that.
> One more thing, > Did you test this patch with the board? > If not, I will not accept this patch, unless other people send 'Tested-by'.
I've tested the driver on the Sony Xperia Z3 and it visually behaves as expected.
I'll send you an updated patch shortly.
Thank you, Bjorn
| |