lkml.org 
[lkml]   [2015]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: running out of tags in 9P (was Re: [git pull] vfs part 2)
    On Thu, Jul 02, 2015 at 10:19:07AM +0300, Andrey Ryabinin wrote:
    > On 07/02/2015 07:10 AM, Al Viro wrote:
    > >>
    > >> It should be easy to confirm - in p9_client_prepare_req() add
    > >> if (WARN_ON_ONCE(tag != (u16)tag)) {
    > >> p9_idpool_put(tag, c->tagpool);
    > >> return ERR_PTR(-ENOMEM);
    > >> }
    > >> right after
    > >> tag = p9_idpool_get(c->tagpool);
    > >> if (tag < 0)
    > >> return ERR_PTR(-ENOMEM);
    > >>
    > >> and see if it triggers. I'm not sure if failing with ENOMEM is the
    > >> right response (another variant is to sleep there until the pile
    > >> gets cleaned or until we get killed), and WARN_ON_ONCE() is definitely
    > >> not for the real work, but it will do for confirming that this is what
    > >> we are hitting.
    > >
    >
    > Apparently, I'm seeing something else. That WARN_ON_ONCE didn't trigger.

    While the one in p9_client_write() (on rsize < count) did?


    \
     
     \ /
      Last update: 2015-07-02 10:21    [W:2.744 / U:0.772 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site