lkml.org 
[lkml]   [2015]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/2] tools/testing/nvdimm: Delete an unnecessary check before the function call "vfree"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Thu, 2 Jul 2015 19:24:27 +0200

    The vfree() function performs also input parameter validation.
    Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    tools/testing/nvdimm/test/nfit.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/testing/nvdimm/test/nfit.c b/tools/testing/nvdimm/test/nfit.c
    index 4b69b83..9c910f1 100644
    --- a/tools/testing/nvdimm/test/nfit.c
    +++ b/tools/testing/nvdimm/test/nfit.c
    @@ -270,7 +270,7 @@ static void *__test_alloc(struct nfit_test *t, size_t size, dma_addr_t *dma,
    err:
    if (buf && !is_vmalloc_addr(buf))
    dma_free_coherent(dev, size, buf, *dma);
    - else if (buf)
    + else
    vfree(buf);
    kfree(res);
    kfree(nfit_res);
    --
    2.4.5


    \
     
     \ /
      Last update: 2015-07-02 21:21    [W:4.504 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site