Messages in this thread Patch in this message | | | Date | Thu, 02 Jul 2015 18:45:53 +0200 | From | SF Markus Elfring <> | Subject | [PATCH] netlink: Delete an unnecessary check before the function call "module_put" |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Thu, 2 Jul 2015 18:38:12 +0200
The module_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- net/netlink/af_netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index dea9253..9a0ae71 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -158,7 +158,7 @@ static int __netlink_remove_tap(struct netlink_tap *nt) out: spin_unlock(&netlink_tap_lock); - if (found && nt->module) + if (found) module_put(nt->module); return found ? 0 : -ENODEV; -- 2.4.5
| |