lkml.org 
[lkml]   [2015]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] net-ipv6: Delete an unnecessary check before the function call "free_percpu"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Thu, 2 Jul 2015 16:30:24 +0200

    The free_percpu() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    net/ipv6/route.c | 5 +----
    1 file changed, 1 insertion(+), 4 deletions(-)

    diff --git a/net/ipv6/route.c b/net/ipv6/route.c
    index 1a1122a..6090969 100644
    --- a/net/ipv6/route.c
    +++ b/net/ipv6/route.c
    @@ -369,10 +369,7 @@ static void ip6_dst_destroy(struct dst_entry *dst)
    struct inet6_dev *idev;

    dst_destroy_metrics_generic(dst);
    -
    - if (rt->rt6i_pcpu)
    - free_percpu(rt->rt6i_pcpu);
    -
    + free_percpu(rt->rt6i_pcpu);
    rt6_uncached_list_del(rt);

    idev = rt->rt6i_idev;
    --
    2.4.5


    \
     
     \ /
      Last update: 2015-07-02 17:01    [W:4.054 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site