lkml.org 
[lkml]   [2015]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] regulator: wm831x-dcdc: Use pointer after NULL check
On Thu, Jul 02, 2015 at 12:19:50PM +0100, Charles Keepax wrote:
> On Thu, Jul 02, 2015 at 12:14:56PM +0100, Mark Brown wrote:

> > It's a bug - either the validation shouldn't be there or it needs to be
> > before the use otherwise it does nothing.

> ARRAY_SIZE being implemented with sizeof's means that no actual
> dereference takes place. But if we have multiple people thinking
> this looks buggy then I guess the code probably isn't clear
> enough at the moment.

Ah, I see. I'd not actually looked at the patch yet only the changelog
quoted in the discussion.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-07-02 13:41    [W:0.048 / U:1.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site