lkml.org 
[lkml]   [2015]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 1/2] bnx2x:Fix error handling in the function bnxc2x_dbcx_set_params
Date
> I am used to sending out one patch per each fix like this for each function.
> If you don't like me doing this I don't when sending patches for your
> subsystem(s).

I think that would be preferable.

> In addition would something like this fix your complains about not fixing error
> handling in bnx2x_dcbnl_update_applist.
> int bnx2x_dcbnl_update_applist(struct bnx2x *bp, bool delall) {
> int i, err = 0;
>
> for (i = 0; i < DCBX_MAX_APP_PROTOCOL && err == 0; i++) {
...
> err = dcb_setapp(bp->dev, &app);
> + if (err)
> + break;

Well, either that or retain the fact there's an error and return it at the end.



\
 
 \ /
  Last update: 2015-07-19 14:41    [W:0.031 / U:0.840 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site