lkml.org 
[lkml]   [2015]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] clocksource: atmel-st: Remove irq handler when clock event is unused
On Fri, 17 Jul 2015, Alexandre Belloni wrote:
> +static int atmel_st_request_irq(struct clock_event_device *dev)
> +{
> + int ret;
> +
> + if (clockevent_state_periodic(dev) || clockevent_state_oneshot(dev))
> + return 0;
> +
> + ret = request_irq(irq, at91rm9200_timer_interrupt,
> + IRQF_SHARED | IRQF_TIMER | IRQF_IRQPOLL,
> + "at91_tick", regmap_st);
> + if (ret) {
> + pr_alert("Unable to setup IRQ\n");
> + return ret;
> + }
> +
> return 0;
> }
>
> static int clkevt32k_set_oneshot(struct clock_event_device *dev)
> {
> + int ret;
> +
> clkdev32k_disable_and_flush_irq();
>
> /*
> * ALM for oneshot irqs, set by next_event()
> * before 32 seconds have passed.
> */
> + ret = atmel_st_request_irq(dev);

You cannot call request_irq() from interrupt disabled context. It
works during early boot because might_sleep() is not active then, but
if that happens during normal runtime it wont work.

Thanks,

tglx


\
 
 \ /
  Last update: 2015-07-18 10:41    [W:0.066 / U:3.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site