| Date | Fri, 17 Jul 2015 11:20:26 +0200 | From | Johan Hovold <> | Subject | Re: [PATCH/RFC 12/51] leds: lm3533: Remove work queue |
| |
On Fri, Jul 17, 2015 at 10:46:58AM +0200, Jacek Anaszewski wrote: > From: Andrew Lunn <andrew@lunn.ch> > > Now the core implements the work queue, remove it from the driver. > > Signed-off-by: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com> > Cc: Johan Hovold <johan@kernel.org> > --- > drivers/leds/leds-lm3533.c | 30 ++++++------------------------ > 1 file changed, 6 insertions(+), 24 deletions(-) > > diff --git a/drivers/leds/leds-lm3533.c b/drivers/leds/leds-lm3533.c > index 6e2e020..52496d8 100644 > --- a/drivers/leds/leds-lm3533.c > +++ b/drivers/leds/leds-lm3533.c > @@ -17,7 +17,6 @@
> @@ -123,27 +119,17 @@ out: > return ret; > } > > -static void lm3533_led_work(struct work_struct *work) > -{ > - struct lm3533_led *led = container_of(work, struct lm3533_led, work); > - > - dev_dbg(led->cdev.dev, "%s - %u\n", __func__, led->new_brightness); > - > - if (led->new_brightness == 0) > - lm3533_led_pattern_enable(led, 0); /* disable blink */ > - > - lm3533_ctrlbank_set_brightness(&led->cb, led->new_brightness); > -} > - > static void lm3533_led_set(struct led_classdev *cdev, > - enum led_brightness value) > + enum led_brightness value)
Unrelated random white-space change.
> { > struct lm3533_led *led = to_lm3533_led(cdev); > > - dev_dbg(led->cdev.dev, "%s - %d\n", __func__, value); > + dev_dbg(led->cdev.dev, "%s - %u\n", __func__, value);
Also an unrelated change.
> + > + if (value == 0) > + lm3533_led_pattern_enable(led, 0); /* disable blink */ > > - led->new_brightness = value; > - schedule_work(&led->work); > + lm3533_ctrlbank_set_brightness(&led->cb, value); > }
Johan
|