Messages in this thread | | | Date | Thu, 16 Jul 2015 14:28:18 -0700 | From | Sukadev Bhattiprolu <> | Subject | Re: [PATCH v3 3/8] perf: Add a flags parameter to pmu txn interfaces |
| |
Peter Zijlstra [peterz@infradead.org] wrote: | On Tue, Jul 14, 2015 at 08:01:50PM -0700, Sukadev Bhattiprolu wrote: | > @@ -1604,6 +1613,12 @@ static void power_pmu_start_txn(struct pmu *pmu) | > static void power_pmu_cancel_txn(struct pmu *pmu) | > { | > struct cpu_hw_events *cpuhw = this_cpu_ptr(&cpu_hw_events); | > + int txn_flags; | > + | > + txn_flags = cpuhw->txn_flags; | > + cpuhw->txn_flags = 0; | > + if (cpuhw->txn_flags & ~PERF_PMU_TXN_ADD) | > + return; | | That seems, unintentional? ;-)
Argh. Thanks for catching it.
Sukadev
| |