lkml.org 
[lkml]   [2015]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Xen-devel] [PATCH v2 14/20] xen/grant-table: Make it running on 64KB granularity
Hi Stefano,

On 16/07/2015 16:47, Stefano Stabellini wrote:
>> diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c
>> index 3679293..0a1f903 100644
>> --- a/drivers/xen/grant-table.c
>> +++ b/drivers/xen/grant-table.c
>
> The arm part is fine, but aren't you missing the change to RPP and SPP?

SPP has been removed by commit 548f7c94759ac58d4744ef2663e2a66a106e21c5
as it was unused.

For RPP, it's used internally so there is no need to switch to
XEN_PAGE_SIZE. Otherwise we will waste 60KB for each internal page
allocated (see gnttab_init).

Regards,

--
Julien Grall


\
 
 \ /
  Last update: 2015-07-16 18:41    [W:0.861 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site