Messages in this thread | | | Date | Thu, 16 Jul 2015 13:30:36 +0800 | From | Tang Chen <> | Subject | Re: [PATCH 1/1] mem-hotplug: Handle node hole when initializing numa_meminfo. |
| |
On 07/16/2015 05:20 AM, Tejun Heo wrote: > On Wed, Jul 01, 2015 at 11:16:54AM +0800, Tang Chen wrote: > ... >> - /* and there's no empty block */ >> - if (bi->start >= bi->end) >> + /* and there's no empty or non-exist block */ >> + if (bi->start >= bi->end || >> + memblock_overlaps_region(&memblock.memory, >> + bi->start, bi->end - bi->start) == -1) > Ugh.... can you please change memblock_overlaps_region() to return > bool instead?
Well, I think memblock_overlaps_region() is designed to return the index of the region overlapping with the given region. Maybe it had some users before.
Of course for now, it is only called by memblock_is_region_reserved().
It is OK to change the return value of memblock_overlaps_region() to bool. But any caller of memblock_is_region_reserved() should also be changed.
I think it is OK to leave it there.
Thanks.
> > Thanks. >
| |