lkml.org 
[lkml]   [2015]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] gpio/xilinx: Use correct address when setting initial values.
From
On Wed, Jun 24, 2015 at 9:19 AM, Raphaël Teysseyre <rteysseyre@gmail.com> wrote:

> xgpio_save_regs() is used in this driver to setup the initial
> values of the registers in the hardware.
>
> The relevant registers at that time are:
> 0x0 -> channel 0 data (32 bits, one for each GPIO on this channel).
> 0x4 -> channel 0 tri, controls in/out status for each GPIO of this channel.
> 0x8 -> channel 1 data
> 0xC -> channel 1 tri
>
> gpio-xilinx.c defines these:
> XGPIO_DATA_OFFSET (0x0)
> XGPIO_TRI_OFFSET (0x4)
> XGPIO_CHANNEL_OFFSET 0x8
>
> Before this patch, the "data" register value of channel 1 was written
> at 0x4 intead of 0x8 (overwriting the channel 0 "tri" register),
> and the "tri" register value for channel 1 was written at 0x8 instead of 0xC.
>
> Signed-off-by: Raphaël Teysseyre <rteysseyre@gmail.com>

Patch applied with review tags.

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2015-07-16 13:41    [W:2.573 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site