lkml.org 
[lkml]   [2015]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/5] ARM: OMAP2+: DRA7: clockdomain: change l4per2_7xx_clkdm to SW_WKUP
On Wed, 15 Jul 2015, Paul Walmsley wrote:

> On Wed, 3 Jun 2015, Vignesh R wrote:
>
> > Legacy IPs like PWMSS, present under l4per2_7xx_clkdm, cannot support
> > smart-idle when its clock domain is in HW_AUTO on DRA7 SoCs. Hence,
> > program clock domain to SW_WKUP.
> >
> > Signed-off-by: Vignesh R <vigneshr@ti.com>
> > ---
> > arch/arm/mach-omap2/clockdomains7xx_data.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/mach-omap2/clockdomains7xx_data.c b/arch/arm/mach-omap2/clockdomains7xx_data.c
> > index 57d5df0c1fbd..7581e036bda6 100644
> > --- a/arch/arm/mach-omap2/clockdomains7xx_data.c
> > +++ b/arch/arm/mach-omap2/clockdomains7xx_data.c
> > @@ -331,7 +331,7 @@ static struct clockdomain l4per2_7xx_clkdm = {
> > .dep_bit = DRA7XX_L4PER2_STATDEP_SHIFT,
> > .wkdep_srcs = l4per2_wkup_sleep_deps,
> > .sleepdep_srcs = l4per2_wkup_sleep_deps,
> > - .flags = CLKDM_CAN_HWSUP_SWSUP,
> > + .flags = CLKDM_CAN_SWSUP,
> > };
> >
> > static struct clockdomain mpu0_7xx_clkdm = {
>
> Thanks, queued for v4.2-rc fixes. Note that I cannot test this, since I
> don't have a DRA7xx board.

You know, upon further thought, this doesn't make sense. If the bug
is with the PWMSS IP block specifically, why not just set
HWMOD_SWSUP_SIDLE on all the IP blocks where the hardware folks didn't
implement hardware smart-idle? At least that way, if those legacy IP
blocks aren't in use, the clockdomain can still enter hardware-supervised
idle?

This patch basically disables hardware-supervised/smart idle for all of
the IP blocks in that clockdomain?


- Paul


\
 
 \ /
  Last update: 2015-07-15 22:41    [W:0.316 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site